Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed quick access widgets when there are few items #11169

Merged
merged 7 commits into from Feb 6, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Feb 5, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Fixes an issue where the recent folders widgets misbehaves when there are few pinned folder.
Current code works assuming the non-pinned items are the last 4 which is not always the case.
This PR looks instead at the "System.Home.IsPinned" property.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Feb 5, 2023

Fyi @hecksmosis

Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't know the property existed

@yaira2 yaira2 changed the title Fix: Fix recent folders widgets when there are few items Fix: Fixed quick access widgets when there are few items Feb 6, 2023
@yaira2 yaira2 added the approved label Feb 6, 2023
@yaira2 yaira2 merged commit b2e3288 into files-community:main Feb 6, 2023
@gave92 gave92 deleted the recent_noactivator branch February 6, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants