Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Moved "format drive" to main context menu #11364

Merged
merged 12 commits into from Feb 21, 2023
Merged

Feature: Moved "format drive" to main context menu #11364

merged 12 commits into from Feb 21, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@yaira2
Copy link
Member

yaira2 commented Feb 19, 2023

Can you do this with BaseLayout as well?

@hecksmosis
Copy link
Contributor Author

Can you do this with BaseLayout as well?

When would this be used?

@yaira2
Copy link
Member

yaira2 commented Feb 19, 2023

When right clicking a blank space

@hecksmosis
Copy link
Contributor Author

Ok

@hecksmosis
Copy link
Contributor Author

Done

yaira2
yaira2 previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Move format drive to main context menu Feature: Moved "format drive" to main context menu Feb 20, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 20, 2023 •
edited

Does right clicking a sub folder in c:\ crash the app for you?

@yaira2
Copy link
Member

yaira2 commented Feb 21, 2023

The crash is fixed but the menu doesn't load when right clicking a selected folder.

@hecksmosis
Copy link
Contributor Author

Yes, I know, this is because of an bug in a merge in #11365 with #11357

@hecksmosis
Copy link
Contributor Author

Fixed

yaira2
yaira2 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 6f95b3f into files-community:main Feb 21, 2023
@mafra99 mafra99 mentioned this pull request Feb 21, 2023
Merged
2 tasks
@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

When right clicking a blank space

I just checked and this is actually not a valid use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Option to format drives should be displayed in the main menu
2 participants
@hecksmosis @yaira2