Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue were clicking tags in columns layout would crash app #11718

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details
Now search results are displayed only in DetailsLayout
There's a limitation where you can't use Double-Click-To-Go-Up in search results opened from column view, still it works from the toolbar. This happens because of ShellPages.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 changed the title Fixed: Tags in columns view crashes application Fix: Fixed issue were clicking tags in columns layout would crash app Mar 14, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 9c70d8d into files-community:main Mar 16, 2023
1 check passed
@ferrariofilippo ferrariofilippo deleted the Open_Search_Results_In_Details branch March 16, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tags in columns view crashes application
2 participants