Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Only open single tab if user holds down ctrl + t #11743

Merged
merged 1 commit into from Mar 16, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related: Feature: Only execute certain actions once #11737

Changes

  • I added Win key cases in OnPreviewKeyUp() to remove them from modifiers
  • keyReleased ensures that the shortcut is executed only once while the key is pressed
  • This PR does not address all the use cases listed in the related Feature Request, since they have not yet been implemented as RichCommands.
  • I tested the behaviour of Show Preview Pane and Open New Tab

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you implement any design changes to an existing feature?
    • Was this change approved?

@yaira2
Copy link
Member

yaira2 commented Mar 16, 2023

For some shortcuts, we still want users to be able to hold down on the key (eg. ctrl + tab). Can you confirm this still works?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 0a95fce into files-community:main Mar 16, 2023
1 check passed
@ferrariofilippo ferrariofilippo deleted the Execute_Actions_Once branch March 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants