Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue with browsing WSL drives #11793

Merged
merged 4 commits into from Mar 22, 2023

Conversation

mafra99
Copy link
Contributor

@mafra99 mafra99 commented Mar 21, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: WSL File Browsing issue #11272

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Navigated through a WSL distribution
    2. For network shares it still asks for credentials

Notes

@yaira2 yaira2 changed the title Fix: Fixed issue while browsing WSL drives Fix: Fixed issue with browsing WSL drives Mar 21, 2023
@yaira2 yaira2 requested a review from hez2010 March 21, 2023 20:05
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it but there seems to be an error in the code logic

src/Files.App/Filesystem/WSLDistroManager.cs Outdated Show resolved Hide resolved
mafra99 and others added 2 commits March 22, 2023 15:41
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@mafra99
Copy link
Contributor Author

mafra99 commented Mar 22, 2023

I can't test it but there seems to be an error in the code logic

What exectly do you mean with that? Is there anything else i should test?

With the changes of this PR, the access to WSL distributions & network drives (with credentials) works for me:

Files_3DNUvycpPr.mp4

@ferrariofilippo
Copy link
Contributor

What exectly do you mean with that? Is there anything else i should test?

I meant that you were normalizing the path but then you were using the raw path instead of the normalized one. Now you changed that and it's ok

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit b428e71 into files-community:main Mar 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: WSL File Browsing issue
3 participants