Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Translate shell folders names & avoid possible bugs #11890

Merged
merged 12 commits into from Apr 2, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes N/A

Change List

  • Now Shell Folders have a tooltip in the sidebar (Before it was empty)
  • Path box will show This PC instead of the whole Shell folder path
  • Prevent paths such as RecycleBin/.. which will probably cause issues
  • Localize Shell Folders names in JumpList, TabName, Path box
  • Removed LocalSettings translation of RecycleBin

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Navigate to shell folders

@yaira2 yaira2 changed the title Fixed: Translate shell folders names & avoid possible bugs Fix: Translate shell folders names & avoid possible bugs Mar 29, 2023
@yaira2 yaira2 changed the title Fix: Translate shell folders names & avoid possible bugs Feature: Translate shell folders names & avoid possible bugs Mar 29, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 03286c5 into files-community:main Apr 2, 2023
1 check passed
@ferrariofilippo ferrariofilippo deleted the Shell_Folder_Names branch April 2, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants