Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: New Logging provider #11937

Merged
merged 7 commits into from Apr 2, 2023
Merged

Feature: New Logging provider #11937

merged 7 commits into from Apr 2, 2023

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Apr 1, 2023

Closes #11918

  • Switches logging to go through the centralized generic host
  • Sets the default logging level to LoggingLevel.Information
  • Creates a simple FileLoggingProvider since a default implementation isn't available yet
  • Removes old platform-specific log writer
  • Changes remaining parts of app to use new ILogger
  • Entries with LogLevel.Warning or higher will also be written to the Windows Event Log
  • Incorporate changes from Fix: Remove unnecessary log spam #11933 (by @hecksmosis)

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
image

hecksmosis
hecksmosis previously approved these changes Apr 2, 2023
yaira2
yaira2 previously approved these changes Apr 2, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Apr 2, 2023

@lukeblevins can you fix the merge conflict?

@lukeblevins lukeblevins dismissed stale reviews from yaira2 and hecksmosis via fb1f157 April 2, 2023 14:31
@lukeblevins lukeblevins requested a review from yaira2 April 2, 2023 14:32
@yaira2 yaira2 merged commit 20ebfe3 into files-community:main Apr 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: DetectQuickLookAvailability|QuickLook detected: False spammed in log file
3 participants