Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improved shell extension loading #11940

Merged

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Apr 2, 2023

It loads main menu first, then loads Open with submenu, Send to submenu and other submenus in order.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Improve shell extension loading performance #11882

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

GIF (2.4.60 is light, this PR is dark)
無題の動画 ‐ Clipchampで作成

@yaira2
Copy link
Member

yaira2 commented Apr 2, 2023

Right clicking a folder with media files is causing the window to become unresponsive

Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We just need to rename that method since it's async now

src/Files.App/BaseLayout.cs Outdated Show resolved Hide resolved
src/Files.App/BaseLayout.cs Outdated Show resolved Hide resolved
src/Files.App/BaseLayout.cs Outdated Show resolved Hide resolved
hishitetsu and others added 3 commits April 2, 2023 23:11
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
@hishitetsu
Copy link
Member Author

Right clicking a folder with media files is causing the window to become unresponsive

In my environment, I can right-click a folder with some screenshots normally.
Doesn't it become unresponsive in 2.4.60?

@yaira2
Copy link
Member

yaira2 commented Apr 2, 2023

In my environment, I can right-click a folder with some screenshots normally.

Can you try with music files?

Doesn't it become unresponsive in 2.4.60?

It works fine in v2.4.60 but perhaps that's because it's in release mode.

@hishitetsu
Copy link
Member Author

Can you try with music files?

It works fine for me.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 38c43a8 into files-community:main Apr 2, 2023
1 check passed
@hishitetsu hishitetsu deleted the ImproveShellExtensionLoading branch April 2, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Improve shell extension loading performance
3 participants