New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Improved shell extension loading #11940
Feature: Improved shell extension loading #11940
Conversation
Right clicking a folder with media files is causing the window to become unresponsive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We just need to rename that method since it's async now
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
Co-authored-by: Luke Blevins <lukeblevins15@outlook.com>
In my environment, I can right-click a folder with some screenshots normally. |
Can you try with music files?
It works fine in v2.4.60 but perhaps that's because it's in release mode. |
It works fine for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It loads main menu first, then loads Open with submenu, Send to submenu and other submenus in order.
Resolved / Related Issues
Closes Feature: Improve shell extension loading performance #11882
Validation
How did you test these changes?
GIF (2.4.60 is light, this PR is dark)