Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed sorting and grouping not working in column view #12056

Merged
merged 1 commit into from Apr 16, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Apr 12, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes (partially) Bug: Sort does not work in Column View #12045

NOTE: with this change sorting and grouping in column view work but the chosen sorting options do not "stick" (navigating to another folder and back will reset the options). I believe this always used to be the case, so perhaps we can merge this PR as is and work on saving the sorting options later.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Verify that sorting and gouping are correctly applied to the selected column

Screenshots (optional)
Add screenshots here.

@yaira2
Copy link
Member

yaira2 commented Apr 14, 2023

I believe this always used to be the case, so perhaps we can merge this PR as is and work on saving the sorting options later.

Is there an issue to track this?

@gave92
Copy link
Member Author

gave92 commented Apr 14, 2023

Not that I can find, will open one

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit ac31532 into files-community:main Apr 16, 2023
1 check passed
@gave92 gave92 deleted the sort_column branch April 16, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants