Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Renamed Preferences to General #12086

Merged
merged 5 commits into from Apr 16, 2023
Merged

Feature: Renamed Preferences to General #12086

merged 5 commits into from Apr 16, 2023

Conversation

LouisFriedmann
Copy link
Contributor

@LouisFriedmann LouisFriedmann commented Apr 16, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Preferences tab in Settings should be renamed #12077

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...
    3. Verify that "Preferences" is called "General"
    4. Verify that "General" is the first tab in the settings menu

Screenshots (optional)
Add screenshots here.

yaira2
yaira2 previously approved these changes Apr 16, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 changed the title Feature; Renamed preferences to General Feature: Renamed preferences to General Apr 16, 2023
@yaira2 yaira2 changed the title Feature: Renamed preferences to General Feature: Renamed Preferences to General Apr 16, 2023
@yaira2 yaira2 merged commit 0a4985b into files-community:main Apr 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Preferences tab in Settings should be renamed
2 participants