Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed an issue where the right-click menu would sometimes freeze the app #12686

Merged
merged 2 commits into from Jun 22, 2023
Merged

Fix: Fixed an issue where the right-click menu would sometimes freeze the app #12686

merged 2 commits into from Jun 22, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Freeze when right clicking #12598

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@yaira2 yaira2 changed the title Fix: Fixed possible freezing when right-clicking Fix: Fixed an issue where the right-click menu would sometimes freeze the app Jun 22, 2023
@hishitetsu hishitetsu requested a review from yaira2 June 22, 2023 16:01
yaira2
yaira2 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit dfb0caa into files-community:main Jun 22, 2023
1 check passed
@hishitetsu hishitetsu deleted the FixGetShellNewRegistryEntries branch June 22, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Freeze when right clicking
2 participants
@hishitetsu @yaira2