Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash that would occur when adding a new tab #12840

Merged
merged 1 commit into from Jul 4, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Jul 4, 2023

I believe this happens when the view model (ViewModel) is replaced and the property within it (IsPageTypeNotHome) is changed at the same time. So I added a dedicated property that controls whether the selection/layout/sort buttons are displayed or not. This is the same mechanism that controls the preview button display.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Clicking new tab button crashes app #12826

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the approved label Jul 4, 2023
@yaira2 yaira2 changed the title Fix: Fixed crash sometimes occurring when adding a new tab Fix: Fixed crash that would occur when adding a new tab Jul 4, 2023
@yaira2 yaira2 merged commit 6df8569 into files-community:main Jul 4, 2023
2 checks passed
@hishitetsu hishitetsu deleted the FixNewTabCrash branch July 4, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Clicking new tab button crashes app
2 participants