Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Reflect current layout in the Toolbar #12915

Merged
merged 5 commits into from Jul 10, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Update layout button icon as layout changes #12894

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app and navigate to a folder
    2. Change layout

Screenshots (optional)
image

@yaira2
Copy link
Member

yaira2 commented Jul 10, 2023

@mdtauk would it look better if we used a single icon to represent whenever a grid layout is selected?

@mdtauk
Copy link

mdtauk commented Jul 10, 2023

The majority of layout options are some kind of grid.

@ferrariofilippo
Copy link
Contributor Author

What should we do then?
Also, can we sort layouts as below:
image

I think it would be better to have the three grid layouts in the same column

@yaira2
Copy link
Member

yaira2 commented Jul 10, 2023

Also, can we sort layouts as below:

Do you want me to push a commit for this?

@ferrariofilippo
Copy link
Contributor Author

Do you want me to push a commit for this?

I can do it

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Update layout button icon as layout changes Feature: Reflect current layout in the Toolbar Jul 10, 2023
@yaira2 yaira2 merged commit 93ee5d3 into files-community:main Jul 10, 2023
1 of 2 checks passed
@ferrariofilippo ferrariofilippo deleted the Display_Current_Layout branch July 10, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Update layout button icon as layout changes
3 participants