New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Use thread-safe collections in ItemViewModel #12949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to do something in the Remove*
methods
src/Files.App/Helpers/StorageItemCollection/ConcurrentCollection.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Helpers/StorageItemCollection/ConcurrentCollection.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Helpers/StorageItemCollection/ConcurrentCollection.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Helpers/StorageItemCollection/ConcurrentCollection.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Helpers/StorageItemCollection/ConcurrentCollection.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Helpers/StorageItemCollection/ConcurrentCollection.cs
Outdated
Show resolved
Hide resolved
@ferrariofilippo thank you for reviewing. I'll check when I have more time. |
Fixed except for one point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I believe this may avoid crashes like #12924.
Resolved / Related Issues
Related to Code Quality: Use thread-safe collections if accessed by multiple threads #12617
Validation
How did you test these changes?