Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Use thread-safe collections in ItemViewModel #12949

Merged
merged 3 commits into from Jul 16, 2023

Conversation

hishitetsu
Copy link
Member

I believe this may avoid crashes like #12924.

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to do something in the Remove* methods

@hishitetsu
Copy link
Member Author

@ferrariofilippo thank you for reviewing. I'll check when I have more time.
Incidentally, this was created by referring to BulkConcurrentObservableCollection and removing unnecessary code.
https://github.com/files-community/Files/blob/794e7e489aa34690457bdd661972486274e284c8/src/Files.App/Helpers/StorageItemCollection/BulkConcurrentObservableCollection.cs

@hishitetsu
Copy link
Member Author

I think you forgot to do something in the Remove* methods

Fixed except for one point.

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 0c58a82 into files-community:main Jul 16, 2023
1 check passed
@hishitetsu hishitetsu deleted the ConcurrentCollection branch July 17, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants