Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash when launching from CMD with "Files" #13023

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    Launch the app from CMD with "files C:". You will see the app launches successfully.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed crash when launching from CMD with "files" Fix: Fixed crash when launching from CMD with "Files" Jul 21, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 21, 2023
@yaira2 yaira2 merged commit 12a7297 into files-community:main Jul 21, 2023
1 check was pending
@hishitetsu hishitetsu deleted the LaunchFromCmd branch July 21, 2023 14:38
@pierrishm1987
Copy link

Great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Launching first instance of Files with arguments doesn't work anymore
3 participants