Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for previewing Office files #13096

Merged
merged 24 commits into from Aug 30, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jul 28, 2023

Resolved / Related Issues

Status

  • The preview renders in the correct z-order
  • The preview accepts mouse/keyboard input (hackish)
  • The preview follows system theme, not Files setting (light/dark)
  • ContentExternalOutputLink requires experimental version of WinAppSdk

Validation
How did you test these changes?

  • Did you build the app and test your changes?

Screenshots (optional)
Screenshot 2023-07-28 202017

@mdtauk
Copy link

mdtauk commented Jul 29, 2023

Is there any way to contain these Win32 controls better to ensure a good and consistent Preview Pane design?

image

@yaira2
Copy link
Member

yaira2 commented Jul 30, 2023

@ahmed605 fyi

@yaira2
Copy link
Member

yaira2 commented Aug 15, 2023

@gave92 is there supposed to be a way to select text when previewing a Word document?

@yaira2
Copy link
Member

yaira2 commented Aug 16, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gave92
Copy link
Member Author

gave92 commented Aug 20, 2023

Works nicely with PowerToys previews :)

Files.-.Files.2023-08-20.12-30-02.mp4

@yaira2
Copy link
Member

yaira2 commented Aug 23, 2023

@gave92 fantastic!

@yaira2 yaira2 changed the title Feature: Add support for Office files preview Feature: Added support for previewing Office files Aug 30, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 marked this pull request as ready for review August 30, 2023 21:13
@yaira2 yaira2 merged commit 2163d64 into files-community:main Aug 30, 2023
1 of 2 checks passed
@gave92 gave92 deleted the preview_docx branch August 31, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants