Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Automatically update items when the date changes #13119

Merged
merged 5 commits into from Aug 3, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Aug 2, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Automatically update date differences #13109

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    Following date displays will automatically update:
    • Date columns in the Details layout
    • Tooltips in the Tile, Grid and Column layout (each time a tooltip pops up)
    • Date displays in the General properties page
    • Date displays in the preview pane
    • Date displays in the Details properties page

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this exception when I try to run the code

image

@hishitetsu
Copy link
Member Author

I get this exception when I try to run the code

Oops, I don't have the environment to build now, I'll fix it later.

@hishitetsu
Copy link
Member Author

I get this exception when I try to run the code

Oops, I don't have the environment to build now, I'll fix it later.

Fixed.

@hishitetsu
Copy link
Member Author

Added support for following displays:

  • Date displays in the preview pane
  • Date displays in the Details properties page

@ferrariofilippo
Copy link
Contributor

  • Date displays in the preview pane
  • Date displays in the Details properties page

Are these supposed to refresh automatically or should they update whenever the content is loaded?

@hishitetsu
Copy link
Member Author

  • Date displays in the preview pane
  • Date displays in the Details properties page

Are these supposed to refresh automatically or should they update whenever the content is loaded?

Now they should be refreshed automatically.

@ferrariofilippo
Copy link
Contributor

Now they should be refreshed automatically.

It doesn't seem to work then

@hishitetsu
Copy link
Member Author

It doesn't seem to work then

Did you pull the latest commit?

@ferrariofilippo
Copy link
Contributor

Did you pull the latest commit?

My bad, I was on Use dispatcherQueue

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Feature: Automatically update date differences Feature: Automatically update items when the date changes Aug 3, 2023
@yaira2 yaira2 merged commit f5d3d0f into files-community:main Aug 3, 2023
2 checks passed
@hishitetsu hishitetsu deleted the UpdateDateDiff branch August 4, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Automatically update date differences
3 participants