Feature: Display keyboard shortcuts in the right click menu

[ferrariofilippo]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Feature: Display keyboard shortcuts in the right click menu #13055

When there's more than one shortcut, should the label display all of them?
There's a bug involving Enter and I'm working on it (if you hit Enter, which is the accelerator for Open, it will cut the item, since that's the first button in the menu)

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open app
  2. Right click on a file / empty space

Screenshots (optional)

[ferrariofilippo]

There's a bug involving Enter and I'm working on it (if you hit Enter, which is the accelerator for Open, it will cut the item, since that's the first button in the menu)

@yaira2 I thought that if we allow Enter accelerator in the context flyout, users won't be able to work with it using only the keyboard. You need to hit Enter to select an action, but doing so would trigger the shortcut.
I think we should prevent this. We may remap Enter shortcuts to something else (like Ctrl + Enter or Shift + Enter) only in the context menu

[yaira2]

@ferrariofilippo is it possible to display the shortcut without adding the accelerators to the context menu? It might be confusing if we used custom shortcuts only in the context menu.

[ferrariofilippo]

@ferrariofilippo is it possible to display the shortcut without adding the accelerators to the context menu? It might be confusing if we used custom shortcuts only in the context menu.

The label would be visible, but the shortcut would not work.
I don't want to use custom shortcuts in the context menu. I think we should change only Enter shortcut to something else, since it would make the context menu inaccessible to keyboard users (all the other shortcuts won't be affected [Ctrl + C, Ctrl + V, Ctrl + Enter, ...]).

[yaira2]

The label would be visible, but the shortcut would not work.

Wouldn't the shortcut work from the rich commands?

[yaira2]

Regarding enter, we can leave that blank 👍

[ferrariofilippo]

The label would be visible, but the shortcut would not work.

Wouldn't the shortcut work from the rich commands?

It seems the context menu handles all the inputs while open, the RichCommands are not invoked

[yaira2]

That's good to know, in that case we can just leave enter blank and fill out the other ones.

[ferrariofilippo]

What about this?

Should we show all the available shortcuts or only the first one?

[yaira2]

Just the first one

[yaira2]

LGTM