Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Load network icon instead of a folder icon #13226

Merged
merged 2 commits into from Aug 21, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 21, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Inconsistency of Network Folder Icon on Sidebar #13219...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Confirm the network item has the correct icon

Screenshots (optional)
image

@yaira2 yaira2 changed the title Fix: Load network icon instead of a blank folder Feature: Load network icon instead of a blank folder Aug 21, 2023
@yaira2
Copy link
Member Author

yaira2 commented Aug 21, 2023

@Lukiluc29

@Lukiluc29
Copy link
Contributor

I tested and it works perfectly.

@yaira2 yaira2 changed the title Feature: Load network icon instead of a blank folder Feature: Load network icon instead of a folder icon Aug 21, 2023
@yaira2 yaira2 merged commit 007f6fb into main Aug 21, 2023
1 check passed
@yaira2 yaira2 deleted the ya/NetworkIcon branch August 21, 2023 18:30
@yaira2
Copy link
Member Author

yaira2 commented Aug 21, 2023

Thank you for checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Inconsistency of Network Folder Icon on Sidebar
2 participants