Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added file operation support for FTP #13362

Merged
merged 7 commits into from Sep 20, 2023

Conversation

NicoooByte
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes partially Feature: Improving FTP support #5833 (Move operation)

Adds feature of moving files and folders in an FTP storage via the FluentFTP library.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots (optional)
None

NicoooByte and others added 3 commits August 25, 2023 11:44
…rageInterface

* Implement the MoveFolderAsync Action in the FtpStorageFolder class via FluentFTP MoveDirectory
* Implement the MoveAsync Action in the FtpStorageFile class via FluentFTP MoveFile
* Fix bug where the folder/files still are displayed after moving into another folder
@yaira2 yaira2 changed the title Feature: move ftp files and folders Feature: Add file operation support for FTP Sep 13, 2023
@yaira2 yaira2 requested a review from gave92 September 13, 2023 13:53
@gave92
Copy link
Member

gave92 commented Sep 17, 2023

Hi, thanks for your contribution!

Please see https://github.com/NicoooByte/Files/pull/1/files for some suggested changes:

  • Restored some of the previous code, needed for operations outside FTP folders
  • Renamed MoveFolderAsync to MoveAsync, to match RenameAsync, etc..
  • Made so the method returns the moved folder

Other than that this is looking good.

@yaira2 yaira2 changed the title Feature: Add file operation support for FTP Feature: Added file operation support for FTP Sep 20, 2023
@yaira2 yaira2 merged commit 05aca27 into files-community:main Sep 20, 2023
1 check passed
@yaira2
Copy link
Member

yaira2 commented Sep 20, 2023

@NicoooByte thank you for your contribution, and congrats on your first pull request!

@NicoooByte NicoooByte deleted the FTP-MoveFilesAndFolders branch September 20, 2023 21:42
@NicoooByte
Copy link
Contributor Author

Thanks, feels good :)

@yaira2
Copy link
Member

yaira2 commented Sep 20, 2023

You happened to have picked one of the more difficult issues, it's a good thing Gave was able to help with the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants