New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added file operation support for FTP #13362
Merged
yaira2
merged 7 commits into
files-community:main
from
NicoooByte:FTP-MoveFilesAndFolders
Sep 20, 2023
Merged
Feature: Added file operation support for FTP #13362
yaira2
merged 7 commits into
files-community:main
from
NicoooByte:FTP-MoveFilesAndFolders
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rageInterface * Implement the MoveFolderAsync Action in the FtpStorageFolder class via FluentFTP MoveDirectory * Implement the MoveAsync Action in the FtpStorageFile class via FluentFTP MoveFile * Fix bug where the folder/files still are displayed after moving into another folder
yaira2
changed the title
Feature: move ftp files and folders
Feature: Add file operation support for FTP
Sep 13, 2023
Hi, thanks for your contribution! Please see https://github.com/NicoooByte/Files/pull/1/files for some suggested changes:
Other than that this is looking good. |
gave92
approved these changes
Sep 20, 2023
yaira2
changed the title
Feature: Add file operation support for FTP
Feature: Added file operation support for FTP
Sep 20, 2023
@NicoooByte thank you for your contribution, and congrats on your first pull request! |
Thanks, feels good :) |
You happened to have picked one of the more difficult issues, it's a good thing Gave was able to help with the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes partially Feature: Improving FTP support #5833 (Move operation)
Adds feature of moving files and folders in an FTP storage via the FluentFTP library.
Validation
How did you test these changes?
Screenshots (optional)
None