Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed an issue where the context menu didn't show all shell items #13388

Merged
merged 1 commit into from Sep 18, 2023
Merged

Fix: Fixed an issue where the context menu didn't show all shell items #13388

merged 1 commit into from Sep 18, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Sep 17, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Add null check on command string

Validation
How did you test these changes?

  • Did you build the app and test your changes?

hishitetsu
hishitetsu approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was just making the same fix myself.

yaira2
yaira2 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed context menu not showing shell items Fix: Fixed an issue where the context menu didn't show all shell items Sep 18, 2023
@yaira2 yaira2 merged commit 0aaaa8d into files-community:main Sep 18, 2023
1 check passed
@gave92 gave92 deleted the right_click branch September 18, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gave92 @yaira2 @hishitetsu