Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Renamed duplicate "Artist" to "Contributing Artists" in properties window #13447

Merged
merged 7 commits into from Oct 9, 2023
Merged

Fix: Renamed duplicate "Artist" to "Contributing Artists" in properties window #13447

merged 7 commits into from Oct 9, 2023

Conversation

hemalshah28
Copy link
Contributor

@hemalshah28 hemalshah28 commented Sep 29, 2023 •
edited

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

Before fix
image

Just for testing I have added one more artist in the same field.

After fix
image

Preview pane fix
image

@yaira2 yaira2 changed the title FIX: for Rename duplicate "Artist" to "Contributing Artists" in properties window Fix: for Rename duplicate "Artist" to "Contributing Artists" in properties window Sep 29, 2023
0x5bfa
0x5bfa reviewed Oct 1, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first time PR.

src/Files.App/Resources/PropertiesInformation.json Outdated Show resolved Hide resolved
src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
hishitetsu
hishitetsu reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the same modification be needed for PreviewPanePropertiesInformation.json?

@hemalshah28
Copy link
Contributor Author

Wouldn't the same modification be needed for PreviewPanePropertiesInformation.json?

yes you are right. It's good catch.

0x5bfa
0x5bfa approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hishitetsu
hishitetsu approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@yaira2 yaira2 changed the title Fix: for Rename duplicate "Artist" to "Contributing Artists" in properties window Fix: Renamed duplicate "Artist" to "Contributing Artists" in properties window Oct 9, 2023
@yaira2 yaira2 merged commit 3896443 into files-community:main Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

@hishitetsu hishitetsu hishitetsu approved these changes

@yaira2 yaira2 Awaiting requested review from yaira2

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Rename duplicate "Artist" to "Contributing Artists" in properties window
4 participants
@hemalshah28 @yaira2 @0x5bfa @hishitetsu