Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Add action to bump version number #13581

Closed

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Oct 26, 2023

Summary

I'd like to introduce the Actions bump up the package version. We're going to be able to use different package file and let the project file choose best package. In that way, we'll need a number of packaging file to distinguish their slight differences such as already shown in #13112.

Important

@yaira2 before merge or approve this PR, please add the token that have write access to the repository called repo:write, which is not included in the default token.

Task Checklist

  • Add package version bump GitHub Actions
  • Clean up
  • Apply requested changes

Known Issues

Following issues would be fixed in the upcoming PR.

N/A

PR Checklist

  • Closes: N/A
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Steps To Validate Changes

N/A

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do, instead.

@yaira2 yaira2 force-pushed the main branch 4 times, most recently from 3ebb408 to eea0fb2 Compare October 31, 2023 01:16
@0x5bfa 0x5bfa closed this Oct 31, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Add-PackageVersionBumpAction branch October 31, 2023 04:02
@0x5bfa 0x5bfa restored the 5bfa/Add-PackageVersionBumpAction branch October 31, 2023 04:03
@0x5bfa 0x5bfa reopened this Oct 31, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 3, 2023

Is there any benefit over doing this manually? We need to type the version number regardless.

@0x5bfa
Copy link
Member Author

0x5bfa commented Nov 3, 2023

You don't need to create a branch and edit the manifest, open a PR.

@yaira2
Copy link
Member

yaira2 commented Nov 4, 2023

It's about the same amount of work but I guess I can review and give it a try.

@yaira2 yaira2 changed the title CI: Add package version bump GitHub Actions GitHub: Add package version bump GitHub Actions Nov 5, 2023
@yaira2 yaira2 changed the title GitHub: Add package version bump GitHub Actions GitHub: Add action to bump version number Nov 7, 2023
@0x5bfa 0x5bfa closed this Nov 14, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Add-PackageVersionBumpAction branch November 14, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants