Fix: Fixed issue where opening properties would download OneDrive files

[yaira2]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Bug: Opening properties for OneDrive file causes the item to be downloaded #13006
  Closes Bug: Items are being auto downloaded in OneDrive, and crash if I cancel download #13593

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open properties for a non OneDrive file/folder and confirm "Size on disk" is calculated
  2. Open properties for a downloaded OneDrive file/folder and confirm "Size on disk" is calculated
  3. Open properties for a non downloaded OneDrive file/folder and confirm "Size on disk" isn't calculated
  4. Open hash page for online file and confirm the file isn't downloaded
  5. Open hash page for offline file and confirm the hash is displayed

Screenshots (optional)
Add screenshots here.

[yaira2]

There still seems to be some issues with folders.

[gave92]

Also for .exe files download happens as soon as you view the folder, happens when you hit this line:

[yaira2]

@gave92 can you check if the latest commit fixes that?

[gave92]

Couple of suggested changes here: #13757.
I find I need to check also for "SyncStatus.FolderOnline".

[gave92]

Looks good. I'm checking again if something more is needed for archive files.

Edit: see https://github.com/files-community/Files/pull/13778/files

Edit 2: for consistency, also turned off folder size computation for combined properties (when 2+ folders are selected)