Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added option to open tab in new/existing instance #13743

Merged
merged 4 commits into from Nov 13, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 8, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2
Copy link
Member Author

yaira2 commented Nov 8, 2023

This helps for Win+E but we need to test for other side effects.

@yaira2 yaira2 changed the title Feature: Win+E in existing instance Feature: Added option to open tab in new/existing instance Nov 12, 2023
@yaira2 yaira2 marked this pull request as ready for review November 12, 2023 16:09
@yaira2
Copy link
Member Author

yaira2 commented Nov 12, 2023

I did some more testing and confirm,

  • Opening Files from the start menu or taskbar will still start a new instance
  • Opening Files from the jumplist, win+e, or other process will open a tab in the existing instance

@yaira2 yaira2 requested a review from gave92 November 12, 2023 16:26
@yaira2 yaira2 merged commit b06d697 into main Nov 13, 2023
6 checks passed
@yaira2 yaira2 deleted the ya/OpenInExistingInstance branch November 13, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add an option to open tab in the existing window instead of opening a new one
1 participant