Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where "Open Files on Windows startup" didn't work #13811

Merged
merged 2 commits into from Nov 12, 2023
Merged

Fix: Fixed issue where "Open Files on Windows startup" didn't work #13811

merged 2 commits into from Nov 12, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Stuck on loading when starting on Windows logon #13720

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

yaira2
yaira2 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 9048508 into files-community:main Nov 12, 2023
6 checks passed
@Yabino
Copy link

Yabino commented Nov 12, 2023

Sorry guys, it's still happening, the bug is still there.

https://drive.google.com/file/d/1NAHuQ2D3KT1qu4l7U3CoPsO6y6TS_kyn/view?usp=sharing

@hishitetsu
Copy link
Member Author

@Yabino It has only been merged into the dev branch right now. The bug should be fixed after the next update.

@hishitetsu hishitetsu deleted the FixStartupLaunch branch November 13, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Stuck on loading when starting on Windows logon
3 participants
@hishitetsu @Yabino @yaira2