Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Removed WidgetsListControl #13941

Merged
merged 5 commits into from Nov 29, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 18, 2023

Summary

Merged widgets list control into Home page.

Task Checklist

  • Removed widgets list control

Known Issues

N/A

PR Checklist

  • Closes: N/A
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Steps To Validate Changes

  1. Launch the app
  2. Go to Home page
  3. See all widgets are shown correctly.

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@0x5bfa 0x5bfa changed the title Code Quality: Refactor Widgets 1 Code Quality: Removed WidgetsListControl Nov 19, 2023
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yaira2 yaira2 requested a review from d2dyno1 November 26, 2023 01:05
@0x5bfa 0x5bfa closed this Nov 28, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Remove-WidgetsListControl branch November 28, 2023 16:07
@0x5bfa 0x5bfa restored the 5bfa/Remove-WidgetsListControl branch November 28, 2023 16:07
@0x5bfa 0x5bfa reopened this Nov 28, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 29, 2023

@0x5bfa thank you

@yaira2 yaira2 merged commit 4ef0adb into files-community:main Nov 29, 2023
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Remove-WidgetsListControl branch November 29, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants