Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Renamed layout page classes to improve readability #13958

Merged
merged 6 commits into from Nov 22, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 19, 2023

Summary

As the title.

Task Checklist

  • Renamed layout page classes to improve readability
  • Clean up
  • Apply requested changes

Steps To Validate Changes

  1. Launch the app
  2. Go to ...

Known Issues

N/A

PR Checklist

  • Development: N/A
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yaira2
yaira2 previously approved these changes Nov 21, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit b3c4d83 into files-community:main Nov 22, 2023
6 checks passed
yaira2 added a commit to ferrariofilippo/Files that referenced this pull request Nov 23, 2023
commit 432b47c
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Thu Nov 23 14:04:12 2023 -0500

    Update FUNDING.yml

commit f42f2ea
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Thu Nov 23 10:01:39 2023 -0500

    Preview: 3.0.11

commit dfc7c2f
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Thu Nov 23 10:00:16 2023 -0500

    Fix: Fixed check for admin (files-community#13971)

commit 79d31e3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Nov 23 09:52:34 2023 -0500

    Build(deps): Bump SQLitePCLRaw.bundle_green from 2.1.6 to 2.1.7 (files-community#14029)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit c0bb1b8
Author: Tony Barrera <antonioseet1@gmail.com>
Date:   Wed Nov 22 18:53:53 2023 -0800

    Fix: Fixed an issue with drag and dropping items onto .py files (files-community#13986)

commit 4b58c2d
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Wed Nov 22 17:12:09 2023 -0500

    Fix: Disable media preview for archive items (files-community#14021)

commit 00543d8
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Wed Nov 22 16:34:25 2023 -0500

    Feature: Indicate "Always keep on device" status (files-community#14012)

commit 92c5231
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Wed Nov 22 14:01:23 2023 -0500

    New Crowdin updates (files-community#14022)

commit b3c4d83
Author: 0x5bfa <62196528+0x5bfa@users.noreply.github.com>
Date:   Thu Nov 23 00:18:41 2023 +0900

    Code Quality: Renamed layout page classes to improve readability (files-community#13958)

commit 1e1bbe7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 22 09:50:51 2023 -0500

    Build(deps): Bump Microsoft.CodeAnalysis.CSharp from 4.5.0 to 4.8.0 (files-community#14017)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 5adae99
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 22 09:50:36 2023 -0500

    Build(deps): Bump Microsoft.Graphics.Win2D from 1.1.0 to 1.1.1 (files-community#14016)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 8e974c7
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Tue Nov 21 21:39:12 2023 -0500

    Feature: Display error when failing to calculate the hash of open files (files-community#14014)

commit bf7b5da
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Tue Nov 21 21:18:46 2023 -0500

    Fix: Fixed NullReferenceException in GetCompressDestination (files-community#14007)

commit 79855ba
Author: Yair <39923744+yaira2@users.noreply.github.com>
Date:   Tue Nov 21 17:36:37 2023 -0500

    Fix: Fixed xamlRoot in the ConsentDialog (files-community#14013)

commit 494153c
Author: William-Hiatt <98793239+William-Hiatt@users.noreply.github.com>
Date:   Tue Nov 21 13:17:49 2023 -0800

    Fix: Fixed "Drive Unplugged" error when compressing items in Column layout (files-community#13695)
@0x5bfa 0x5bfa deleted the 5bfa/Cleanup-Layouts branch November 28, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants