New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Open folder in new tab when dragging folder to "add tab" button #14144
Conversation
Failed the format check on line 1 of MainPage.xaml somehow? |
@denisdekh you can fix the error by running the XAML Styler extension on that file. |
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Thanks for the tip, didn't know about the extention |
This looks good behavior wise |
Let me know if anything else needs to be done, I'll probably start looking for another issue to work on - suggestions are welcome. I am still not that familiar with the app so it's hard to understand what's more important/needed at a glance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's not enough line breaks to keep the codebase looks clean.
Otherwise, LGTM.
/format |
Co-authored-by: 0x5bfa <62196528+0x5bfa@users.noreply.github.com>
commit 82c8d40 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 17 08:03:02 2024 -0800 Preview: 3.1.3 commit 385c54f Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 17 07:56:43 2024 -0800 Fix: Handle InvalidOperationException in RunPowershellCommandAsync (files-community#14481) commit 2acac82 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 17 07:37:54 2024 -0800 Code Quality: Added more null ref protections when renaming items (files-community#14479) commit 6649e82 Author: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com> Date: Tue Jan 16 22:51:58 2024 +0100 Fix: Fixed issue where folders sizes weren't calculated when opening Properties from the sidebar (files-community#14480) commit 16bb923 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Mon Jan 15 13:13:43 2024 -0800 Feature: Add newly created items to Recent Files list (files-community#14466) commit 6a3d1cc Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Jan 16 00:24:51 2024 +0900 Code Quality: Faster background launch at Windows startup (files-community#14464) commit 9368719 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Jan 16 00:23:25 2024 +0900 Fix: Fixed issue where a new tab would open when trying to open a new window (files-community#14463) commit e0d9dfd Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Sun Jan 14 18:43:32 2024 -0500 CodeQuality: Removed CheckFolderAccessWithWin32 from sidebar commit d7ed905 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Mon Jan 15 00:21:59 2024 +0900 Fix: Fixed issue where switching from Details to Tiles didn't reload thumbnails (files-community#14457) commit f3161fe Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Sun Jan 14 09:03:45 2024 +0900 Fix: Fixed COMException with BaseLayoutPage.GetAllItems - part 2 (files-community#14447) commit 4ef4730 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Sun Jan 14 09:03:17 2024 +0900 Fix: Fixed COMException in ItemsAdded_CollectionChanged - part 2 (files-community#14448) commit bb82313 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Fri Jan 12 10:39:33 2024 -0500 Preview: v3.1.2 commit 9eafcf6 Author: Qin-shihuang <68013339+Qin-shihuang@users.noreply.github.com> Date: Fri Jan 12 23:14:31 2024 +0800 Fix: Fixed environment variables expansion for shortcuts (files-community#14425) commit c19f829 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Fri Jan 12 10:04:54 2024 -0500 Feature: Switched away from GetThumbnailAsync API (files-community#14423) commit 246ddac Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Sat Jan 13 00:03:52 2024 +0900 Fix: Fixed COMException in ItemsAdded_CollectionChanged (files-community#14439) commit d2e8980 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Thu Jan 11 16:17:32 2024 -0500 Fix: Fixed issue where it didn't work to pick files when creating new shortcuts (files-community#14422) commit 95b1076 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Fri Jan 12 00:09:38 2024 +0900 Fix: Fixed COMException with BaseLayoutPage.GetAllItems (files-community#14431) commit 45b2d28 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Thu Jan 11 00:18:51 2024 +0900 Fix: Fixed issue where pinned applications were executed in %windir%\System32 (files-community#14420) commit 534da91 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 10 10:18:16 2024 -0500 Strings: Update strings commit 2022300 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 10 10:14:29 2024 -0500 Feature: Updated query to include unindexed items in results (files-community#14415) commit 4e6cf66 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Tue Jan 9 21:40:48 2024 -0500 Feature: Updated to WinAppSDK 1.4.4 (files-community#14414) commit a6c0b25 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Tue Jan 9 21:29:41 2024 -0500 Feature: Added an option to disable auto scroll when navigating up (files-community#14412) commit 9f26eb2 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Tue Jan 9 16:17:29 2024 -0500 Feature: Added support for hiding more items from the context menu (files-community#14408) commit bd8f3b7 Author: Sakura Kade Hansen <137737608+SakuraKade@users.noreply.github.com> Date: Tue Jan 9 22:16:35 2024 +0100 Fix: Fixed issue where directly opening library would invoke explorer.exe (files-community#14336) commit f21c6f6 Author: mbartlett21 <29034492+mbartlett21@users.noreply.github.com> Date: Wed Jan 10 03:21:30 2024 +1000 Fix: Use the Stream API to list streams instead of opening the file (files-community#14398) commit 0cf6e5a Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Jan 9 11:31:25 2024 +0900 Fix: Fixed issue where smart extraction would not work correctly for one folder (files-community#14395) commit 97fa781 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Mon Jan 8 11:32:32 2024 -0500 Release: v3.1.1 commit 43a0d47 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Mon Jan 8 11:31:53 2024 -0500 New Crowdin updates (files-community#14388) commit 34da691 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Jan 9 01:27:10 2024 +0900 Fix: Fixed issue where the app would crash when pinning an executable file (files-community#14387) commit a1d0bc7 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Jan 9 01:12:57 2024 +0900 Fix: Fixed issue where the app would crash when opening the properties window twice (files-community#14386) commit 35cc6ad Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Jan 9 00:31:00 2024 +0900 Fix: Fixed issue where the properties window could not be opened on the home page (files-community#14385) commit bc00d61 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Thu Jan 4 20:27:09 2024 -0500 Release: v3.1 (files-community#14357) commit cebdba5 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Thu Jan 4 20:21:29 2024 -0500 Fix: Fixed COMException when removing focus from the path bar (files-community#14356) commit 71742c3 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Thu Jan 4 11:33:09 2024 -0500 Fix: Fixed NullReferenceException when renaming files (files-community#14350) commit fa2caab Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 3 23:10:38 2024 -0500 Fix: Fixed NullReferenceException in ColumnShellPage.NavigateToPath (files-community#14351) commit 96b5fb7 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 3 18:26:38 2024 -0500 New Crowdin updates (files-community#14352) commit c63e568 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Wed Jan 3 11:29:43 2024 -0500 Fix: Fixed issue where batch files were opened as system32 (files-community#14101) commit be0acbd Author: Qin-shihuang <68013339+Qin-shihuang@users.noreply.github.com> Date: Wed Jan 3 00:26:55 2024 +0800 Fix: Fixed the taskbar behavior in full screen mode (files-community#14300) commit 962f2cc Author: Poker <poker_sang@outlook.com> Date: Tue Jan 2 23:35:38 2024 +0800 Code Quality: Migrate to InputNonClientPointerSource (files-community#14342) commit b892e05 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Mon Jan 1 18:23:59 2024 -0500 Fix: Fixed third party notices commit efc5c8a Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Mon Jan 1 10:43:46 2024 -0500 Preview: 3.0.17 commit 62518f2 Author: Steve <hez2010@outlook.com> Date: Mon Jan 1 02:57:29 2024 +0900 Feature: Added an out-of-proc WinRT server for long-running background tasks (files-community#14335) commit ea43865 Author: Marco Franzen <mail@marco-franzen.de> Date: Sun Dec 31 01:34:24 2023 +0100 Feature: Added support for hiding compression options from the context menu (files-community#14330) commit 732f13a Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Sat Dec 30 18:37:00 2023 -0500 Fix: Fixed string name (files-community#14315) commit 1c18f6e Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Fri Dec 29 02:50:17 2023 +0900 Feature: Open minimized window on Windows startup (files-community#14309) commit a481974 Author: Marco Franzen <mail@marco-franzen.de> Date: Thu Dec 28 16:12:24 2023 +0100 Feature: Added an option to group by day (files-community#14299) commit 496e03f Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Thu Dec 28 00:50:54 2023 +0900 Feature: Added support for displaying recently entered paths (files-community#14301) commit 3752486 Author: 0x5bfa <62196528+0x5bfa@users.noreply.github.com> Date: Thu Dec 28 00:30:08 2023 +0900 Feature: Added an icon to the system tray (files-community#14285) commit d15f8f1 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Tue Dec 26 19:31:55 2023 -0500 Fix: Fixed exception that would sometimes occur when sharing items (files-community#14298) commit 3381944 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Dec 26 00:44:30 2023 +0900 Fix: Fixed issue where resuming didn't work once it failed (files-community#14290) commit e2fb851 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Sun Dec 24 08:25:53 2023 +0900 Code Quality: Fixed issue where LastOpenedFlyout was not garbage collected (files-community#14283) commit 528acb5 Author: 0x5bfa <62196528+0x5bfa@users.noreply.github.com> Date: Fri Dec 22 10:43:43 2023 +0900 GitHub: Moved github docs into .github folder (files-community#14276) commit 2e9bdac Author: 0x5bfa <62196528+0x5bfa@users.noreply.github.com> Date: Wed Dec 20 02:04:53 2023 +0900 Code Quality: Introduced SideBarContext (files-community#14116) commit e3f093b Author: 0x5bfa <62196528+0x5bfa@users.noreply.github.com> Date: Wed Dec 20 02:03:18 2023 +0900 Code Quality: Introduced HomePageContext (files-community#14115) commit 3d6715a Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Wed Dec 20 00:05:04 2023 +0900 Fix: Fixed issue where details layout headers weren't always "sticky" (files-community#14262) commit 4c46fc0 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Mon Dec 18 16:14:38 2023 -0500 Preview: v3.0.16 commit c594931 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Dec 19 00:51:36 2023 +0900 Fix: Fixed crash when manipulating invalid images (files-community#14258) commit cf569f2 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Tue Dec 19 00:49:32 2023 +0900 Fix: Fixed issue where options in the conflicts dialog could change when scrolling (files-community#14256) commit d3f06b0 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Mon Dec 18 01:37:50 2023 +0900 Feature: Added option to prioritize files when sorting (files-community#14253) commit 5e9113a Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Sun Dec 17 09:03:51 2023 +0900 Fix: Fixed crash when unable to connect to GitHub (files-community#14246) commit 49d912d Author: Diego Castro <43688047+DMCS20@users.noreply.github.com> Date: Sat Dec 16 19:03:13 2023 -0500 Fix: Fixed file name when pasting clipboard content (files-community#14244) commit f65c918 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Thu Dec 14 14:19:26 2023 -0500 Feature: Prompt when applying tag on non NTFS drive (files-community#14202) commit 609be42 Author: Abdul Derh <12786951+awderh@users.noreply.github.com> Date: Wed Dec 13 16:18:18 2023 -0500 Feature: Recognize Tilde as %USERPROFILE% (files-community#14171) commit f085a0c Author: RieBi <42877671+RieBi@users.noreply.github.com> Date: Wed Dec 13 04:28:38 2023 +0200 Fix: Fixed an issue where selection would get canceled after pressing upper arrow key (files-community#13847) commit 6706117 Author: Denis D <37584435+denisdekh@users.noreply.github.com> Date: Tue Dec 12 15:45:29 2023 -0500 Feature: Open folder in new tab when dragging folder to "add tab" button (files-community#14144) commit 1e9476e Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Wed Dec 13 00:19:47 2023 +0900 Fix: Fixed issue where resizing window would reload preview (files-community#14227) commit ddf3b2a Author: Denis D <37584435+denisdekh@users.noreply.github.com> Date: Mon Dec 11 09:57:50 2023 -0600 Code Quality: Fixed null warnings in MainPage.xaml.cs (files-community#14145) commit ef896ad Author: Nikhil B <59918974+heftymouse@users.noreply.github.com> Date: Sun Dec 10 23:22:05 2023 +0530 GitHub: Add environment to Format XAML workflow (files-community#14217) commit 01970e0 Author: Nikhil B <59918974+heftymouse@users.noreply.github.com> Date: Sun Dec 10 22:45:31 2023 +0530 GitHub: Added auto format XAML command (files-community#13486) commit 3340637 Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Mon Dec 11 00:49:49 2023 +0900 Feature: Added an option for "smart" extract (files-community#14205) commit 0ccf13e Author: hishitetsu <66369541+hishitetsu@users.noreply.github.com> Date: Mon Dec 11 00:28:16 2023 +0900 Fix: Fixed NullReferenceException in LaunchPreviewPopupAction (files-community#14211) commit f5e907f Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Sat Dec 9 19:30:21 2023 -0500 Fix: Fixed crash when creating taskbar progress (files-community#14190) Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com> commit d638827 Author: Marcel Wagner <marcel.alex.wagner@outlook.com> Date: Sun Dec 10 01:18:07 2023 +0100 Fix Sidebar animation not being smooth when sections are sufficiently small (files-community#14206) commit d83ee09 Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Sat Dec 9 19:15:07 2023 -0500 Feature: Treat libraries as root in Columns Layout (files-community#14198) commit f6d62ce Author: Yair <39923744+yaira2@users.noreply.github.com> Date: Sat Dec 9 19:14:58 2023 -0500 Feature: Added 2gb splitting size for archives (files-community#14193)
Resolved / Related Issues
Closes Feature: Drag folder onto "+" icon to create new tab #4710
Also added support for drag opening archives, but commented it out for now as the best solution I was able to find was too ugly in my opinion (parsing the extention from the filename and checking it agaist a list of zip extentions)
Validation
How did you test these changes?
Screenshots (optional)
Too hard to take a screenshot while dragging lol