Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Added stable sideload deployment to the workflow #14218

Closed
wants to merge 14 commits into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Dec 10, 2023

Summary

  • Deleted stable sideload job from azure pipeline file
  • Added stable sideload job to Actions workflow
  • Renamed deploy-preview.yml with deployment.yml
  • Added some helper ps1 scripts

We are going to have three workflows:

  • Files CI (implemented)
  • Files Deployment (in progress)
  • Files Publication (planning stage)

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

@0x5bfa 0x5bfa changed the title GitHub: Added production workflow GitHub: Added stable sideload deployment to the workflow Dec 12, 2023
@0x5bfa 0x5bfa marked this pull request as ready for review December 17, 2023 02:31
@0x5bfa 0x5bfa closed this Jan 22, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Jan 22, 2024

I'm gonna open again when Yair decide to switch.

@yaira2 yaira2 reopened this Jan 22, 2024
@yaira2
Copy link
Member

yaira2 commented Jan 22, 2024

Let's keep open as we're going to need to switch in the next few months

@0x5bfa 0x5bfa closed this Jan 26, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Add-DeploymentCD branch January 26, 2024 18:33
@0x5bfa 0x5bfa restored the 5bfa/Add-DeploymentCD branch January 26, 2024 18:33
@yaira2 yaira2 reopened this Jan 26, 2024
@0x5bfa 0x5bfa marked this pull request as draft February 9, 2024 00:47
@0x5bfa 0x5bfa self-assigned this Feb 9, 2024
@0x5bfa 0x5bfa removed their assignment Feb 9, 2024
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from edf33f7 to c79b2cb Compare March 10, 2024 02:11
@0x5bfa 0x5bfa closed this Mar 23, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Add-DeploymentCD branch March 23, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants