Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Deleted ItemViewModel.ApplySingleFileChangeAsync #14575

Merged

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Jan 29, 2024

This prevents a loophole in #14567.
ApplyFilesAndFoldersChangesAsync is used even for a single file change in most cases, and there is no rational reason to leave ApplySingleFileChangeAsync.

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 29, 2024
@yaira2 yaira2 merged commit 204b26f into files-community:main Jan 29, 2024
6 checks passed
@hishitetsu hishitetsu deleted the DeleteApplySingleFileChangeAsync branch January 30, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants