Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where certain changes in the Properties Window couldn't be canceled #14661

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Some changes in the properties window cannot be canceled #13577

Notes
I found out this bug would affect other properties as well:

  • Is ReadOnly
  • Is Hidden
  • Should be RunAsAdmin (shortcut)
  • Params (shortcut)
  • Target path (shortcut)
  • Working dir (shortcut)

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open the file properties window.
    2. Check the Read-only checkbox.
    3. Press the Cancel button.
    4. Reopen the properties window.
    5. Repeat with IsHidden and with values in the Shortcut tab

yaira2
yaira2 previously approved these changes Feb 7, 2024
@yaira2 yaira2 changed the title Fix: FIxed some changes in the properties window cannot be canceled Fix: Fixed issue where certain changes in the Properties Window couldn't be canceled Feb 7, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 7, 2024
@yaira2 yaira2 merged commit 7839bb0 into files-community:main Feb 7, 2024
5 checks passed
@yaira2
Copy link
Member

yaira2 commented Feb 7, 2024

Thank you

@ferrariofilippo ferrariofilippo deleted the Fix_Properties_Window_Changes_Not_Cancelable branch February 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Some changes in the properties window cannot be canceled
2 participants