Feature: Added audio bitrate to the Details Pane

[Artoryn]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Feature: Add audio file bitrate to details pane #15282

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
    • Small consolidation of formatting of the bitrate display string. This was done as the same formatting was going to be added in a third location so centralizing it and using the DisplayFunctions already present would make more sense.
    • Change the bitrate from 1024 for the conversion to 1000 (bytes to bits), as this would fix the "Sidenote" that the issue mentioned. This was done to make sure the bitrate is calculated off bits and not bytes better matching file explorer's display of this value.
• Are there any other steps that were used to validate these changes?

1. Open app (Audio validation)
2. Navigated to directory with a .mp3, .mp4, and .wav audio file
3. Verified that the Bitrate showed on the Preview Pane Detail window
4. Opened individual file properties window
5. Navigated to the Details section
6. Verified that the Bitrate still showed properly formatted under the properties window

---

1. Open app (Video validation)
2. Navigated to a directory with a .mp4 video file
3. Verified that the Bitrate showed on the Preview Pane Detail window
   a. Added string title text of "Audio Encoding Bitrate" as it seemed unclear for video files which in properties has 2 "Encoding Bitrate" tags under Audio and Video
4. Opened individual file properties window
5. Navigated to the Details section
6. Verified that the Bitrate for Audio and Video still showed properly formatted under the properties window

---

1. Open app (Combined file validation different bitrates)
2. Navigated to a directory with multiple video/audio files
3. Verified that the Bitrate showed on the Preview Pane Detail window for individual files
4. Selected multiple files (with different bitrates)
5. Opened properties window
6. Navigated to the Details section
7. Verified that "(multiple values)" displays under bitrate

---

1. Open app (Combined file validation same bitrates)
2. Navigated to a directory with video/audio file
3. Verified that the Bitrate showed on the Preview Pane Detail window for individual file
4. Create a copy of a file for testing
5. Selected both files (original and copy of file)
6. Opened properties window
7. Navigated to the Details section
8. Verified that the expected Bitrate displays under bitrate

Screenshots (optional)

[hishitetsu]

@Artoryn is this still a work in progress?

[Artoryn]

@Artoryn is this still a work in progress?

No, as long as the few refactors to existing functionality are fine, it is good to go. I marked it Ready for Review.

[0x5bfa]

Sorry for the last stale review.

The code is pretty looking great. LGTM.

[hishitetsu]

@yaira2 what about also adding video encoding bitrate to video files?

[yaira2]

@yaira2 what about also adding video encoding bitrate to video files?

Good idea, I'm on board with this.

[Artoryn]

This was the original reason I added the new text for specifying Audio over just the Encoding Bitrate as well.

Will get these changes pushed.

[hishitetsu]

LGTM 👍

[yaira2]

@Artoryn thank you for contributing to Files.