Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where changing the theme mode could cause a crash #15391

Merged
merged 3 commits into from
May 13, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 13, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Change the theme mode (I’m not sure this is reproducible even often)

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 13, 2024
@yaira2 yaira2 merged commit 2c46d15 into files-community:main May 13, 2024
6 checks passed
@yaira2 yaira2 changed the title Fix: Fixed an issue where the theme mode change would cause a crash Fix: Fixed an issue where changing the theme mode could cause a crash May 13, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Fix-AppThemeModeServiceCrash branch May 14, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: COMException in AppThemeModeService.SetAppThemeMode
2 participants