Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the search feature #2446

Merged
merged 33 commits into from Dec 13, 2020
Merged

Implemented the search feature #2446

merged 33 commits into from Dec 13, 2020

Conversation

lukeblevins
Copy link
Contributor

@lukeblevins lukeblevins commented Nov 26, 2020

For code review purposes. We implement search which allows for recursive queries inside any normal directory. We also aim to support hidden items with this PR.

Limitations: Only indexed locations are queried for performance reasons. We'll add a toggle to change this in a future PR

Fixes #333

@yaira2
Copy link
Member

yaira2 commented Nov 26, 2020

  • We should hide and clear the text in the search box if it loses focus.
  • The path bar should say "Search results in..."
  • The status bar should display the correct item count
  • The auto suggest boxes flyout should sort the results to find the 10 best matching items
  • Switching the directory should clear the text in the search box
  • The option to drag and drop should be disabled on the search results page
  • The option to create new items should be disabled on the search results page
  • The option to open the directory in terminal should be disabled on the search results page
  • Localize all new strings
  • Pressing the space bar in the search box when an item is selected will toggle QuickLook
  • The copy location button should be disabled on the search results page
  • Using the ctrl + r shortcut on the search results page clears the search results and shows the items that were in the searched directory

@ghost ghost added the needs-review label Nov 26, 2020
Files/BaseLayout.cs Outdated Show resolved Hide resolved
@d2dyno1
Copy link
Member

d2dyno1 commented Nov 28, 2020

Hmmm.. It seems like it does not display any search results for me no matter what I search for

Edit:
It looks like items.Count in SearchForUserQueryTextAsync() is 0 so the while loop is skipped

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs-review labels Dec 1, 2020
@Sank30

This comment has been minimized.

@lukeblevins lukeblevins removed the changes requested Changes are needed for this pull request label Dec 11, 2020
yaira2
yaira2 previously approved these changes Dec 13, 2020
@yaira2 yaira2 mentioned this pull request Dec 13, 2020
@yaira2 yaira2 changed the title Search Implemented the search feature Dec 13, 2020
@yaira2 yaira2 merged commit bcf27b4 into master Dec 13, 2020
@yaira2
Copy link
Member

yaira2 commented Dec 13, 2020

@duke7553 Great work!

@yaira2 yaira2 deleted the search branch December 13, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement search options
4 participants