New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented the search feature #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ghost
added
the
needs-review
label
Nov 26, 2020
d2dyno1
reviewed
Nov 28, 2020
Hmmm.. It seems like it does not display any search results for me no matter what I search for Edit: |
yaira2
added
changes requested
Changes are needed for this pull request
and removed
needs-review
labels
Dec 1, 2020
This comment has been minimized.
This comment has been minimized.
… full search queries
… as per contributor feedback
…mmon NavigationToolbar methods via interface, and define new ClearSearchBoxQueryText() method
…ults, add TODO for future property consolidation
lukeblevins
removed
the
changes requested
Changes are needed for this pull request
label
Dec 11, 2020
…the navigation toolbar
yaira2
previously approved these changes
Dec 13, 2020
yaira2
approved these changes
Dec 13, 2020
@duke7553 Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code review purposes. We implement search which allows for recursive queries inside any normal directory. We also aim to support hidden items with this PR.
Limitations: Only indexed locations are queried for performance reasons. We'll add a toggle to change this in a future PR
Fixes #333