Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a details/preview pane #2756

Merged
merged 92 commits into from
Jan 24, 2021
Merged

Added a details/preview pane #2756

merged 92 commits into from
Jan 24, 2021

Conversation

winston-de
Copy link
Contributor

@winston-de winston-de commented Dec 29, 2020 •
edited

This PR adds a details/preview pane for the selected items.

#2450 #130

To-do:

  • Text file preview
  • Markdown file preview
  • Resizable pane
  • Image file preview
  • Support for previews through extensions
  • PDF previews
  • Audio/video file preview
  • .html preview
  • code source files (.cs, .xml. .json) preview (w/ colors!)
  • Bottom-aligned pane for narrow windows
  • Display file properties
  • Pane visibility toggle button and shortcut
  • Opening and closing animations
  • Support for all layouts
  • Add option to disable and edit adaptive preview pane positioning
  • Use x:Load instead of visibility
  • Fix issue where preview pane cuts of part of file browser while collapsed
  • Hide pane on home page
  • Allow details to be provided by extensions and preview controls
  • Display preview text files regardless of extension

For next PR

  • Prevent preview from being refreshed when same file is re-selected
  • Add setting to not load preview for online-only files
  • Different methods of displaying values for details
  • Investigate using icons
  • Fix issue where rectangle selection thing does not stop at preview pane bounds
  • Fix issue where preview pane is refreshed when same file is re-selected
  • Add setting to not load preview for online-only files
2021-01-15-185834_Trim.mp4

Feedback is appreciated! :)

@yaira2 yaira2 self-requested a review January 8, 2021 02:02
@tsvietOK
Copy link
Contributor

Sometimes No details preview is visible.
Steps:

  1. Select archive (or another file without preview)
  2. Fast select video file (or another file with preview)

image

tsvietOK
tsvietOK approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@tsvietOK tsvietOK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsvietOK tsvietOK added ready to merge Pull requests that are approved and ready to merge needs - code review and removed needs - code review ready to merge Pull requests that are approved and ready to merge labels Jan 22, 2021
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 24, 2021
@yaira2
Copy link
Member

yaira2 commented Jan 24, 2021

:shipit:

@yaira2 yaira2 changed the title Details/preview pane Added a details/preview pane Jan 24, 2021
@yaira2 yaira2 merged commit aedb51a into files-community:main Jan 24, 2021
@winston-de winston-de deleted the DetailsPreviewPane branch January 24, 2021 00:53
@Richard-HM Richard-HM mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 left review comments

@d2dyno1 d2dyno1 d2dyno1 left review comments

@tsvietOK tsvietOK tsvietOK approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@winston-de @yaira2 @eraychumak @tsvietOK @mdtauk @d2dyno1 @gave92 @callmehanu