Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved performance when scrolling in large directories #3031

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Improved performance when scrolling in large directories #3031

merged 4 commits into from
Jan 14, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Jan 14, 2021 •
edited

Do you find scrolling on large folders to be smoooother with this PR?
Do you see issues with icons? E.g not loading?

@yaira2 yaira2 self-requested a review January 14, 2021 21:16
@gave92 gave92 marked this pull request as ready for review January 14, 2021 21:19
@yaira2
Copy link
Member

yaira2 commented Jan 14, 2021 •
edited

Do you see issues with icons? E.g not loading?

Icons don't seem to be loading beyond the first 15 or so.

Edit: Icons do eventually load.

@gave92
Copy link
Member Author

gave92 commented Jan 14, 2021 •
edited

@yaichenbaum Never? Sometimes? After switching folder? After switching layout? Only in listview/gridview..?
Slower it's expected but not too much

@yaira2
Copy link
Member

yaira2 commented Jan 14, 2021

@gave92 Other than icons loading a little slower it seems to perform better.

yaira2
yaira2 previously approved these changes Jan 14, 2021
View reviewed changes
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 14, 2021
@yaira2 yaira2 changed the title Improve scrolling performance Improved performance when scrolling in large directories Jan 14, 2021
@yaira2 yaira2 merged commit a7479a3 into files-community:master Jan 14, 2021
@gave92 gave92 deleted the scroll_smooth branch January 15, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gave92 @yaira2