Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle rename correctly when only case changes #3067

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Handle rename correctly when only case changes #3067

merged 1 commit into from
Jan 16, 2021

Conversation

joergpichler
Copy link
Contributor

@joergpichler joergpichler commented Jan 15, 2021 •
edited by gave92

Fixes #3064

@yaira2 yaira2 self-requested a review January 15, 2021 20:16
@gave92
Copy link
Member

gave92 commented Jan 15, 2021

@joergpichler thanks a lot for this PR! Could you verify if this change causes issues with undo/redo?
E.g does pressing Ctrl+Z after renaming a file (changing only case) work?

@joergpichler
Copy link
Contributor Author

@joergpichler thanks a lot for this PR! Could you verify if this change causes issues with undo/redo?
E.g does pressing Ctrl+Z after renaming a file (changing only case) work?

Sure. It still works as expected.
2021-01-16_08h35_43

@gave92 gave92 added the ready to merge Pull requests that are approved and ready to merge label Jan 16, 2021
@yaira2 yaira2 changed the title Handle rename correctly when only case changes (#3064) Handle rename correctly when only case changes Jan 16, 2021
@yaira2
Copy link
Member

yaira2 commented Jan 16, 2021

@joergpichler Great work! LGTM

@yaira2 yaira2 merged commit 7cb75cb into files-community:master Jan 16, 2021
@yaira2 yaira2 mentioned this pull request Jan 16, 2021
Closed
@joergpichler joergpichler deleted the issue-3064 branch January 17, 2021 11:26
@yaira2
Copy link
Member

yaira2 commented Feb 13, 2022

@joergpichler can you take a look at #7625?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 approved these changes

@yaira2 yaira2 Awaiting requested review from yaira2

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename if only change letter-case.
3 participants
@joergpichler @gave92 @yaira2