Added collapsible sections to the sidebar

[oleitao]

Added Drivers and Cloud Drivers collapse groups on left side menu.

[yaira2]

@oleitao Is it possible to make the favorites section collapsible as well?

[oleitao]

@oleitao Is it possible to make the favorites section collapsible as well?

hi, @yaichenbaum yes it's possible, I already have tried that.However, because sidebar controls are loaded as asynchronously the order which each section will be loaded on GUI wil differ.
If create a new section called Home which includes Desktop, Download, Documents, Pictures, Music, Videos, Recycle Bin that section will take some time to be loaded. So, that will be loaded at last at the end of Sidebar control (structure So, below).

Clouc Drivers

• ...
• ...

Drivers

• ...
• ...

Home

• Desktop
• Downloads
• ...
• ...

[gave92]

@oleitao mmm curious, since we do have an order by which sidebar items are loaded. From App.xaml.cs:

await SidebarPinnedController.CreateInstance();    --> load pinned folders
await DrivesManager.EnumerateDrivesAsync();    --> load fixed drives (after pinned folders)
await CloudDrivesManager.EnumerateDrivesAsync();    --> load cloud drives (after drives)
await NetworkDrivesManager.EnumerateDrivesAsync();    --> load network drives (after cloud)

[oleitao]

@gave92 i know that. If @yaichenbaum and @gave92 think it would be better to make the favorites section collapsible as well i can do it? However, i can't assore if i can load drivers sections in correct order.

[gave92]

@oleitao yeah it would be better to make the favorites section collapsible as well but the order of the sidebar sections should be mantained too :) [I don't think I've understood what makes keeping the order difficult]

[yaira2]

@oleitao Can you keep track of the collapsed/expanded state so it's the same whenever the user opens the app? By default, other than the favorites section, all other sections should be collapsed.

[oleitao]

@oleitao Can you keep track of the collapsed/expanded state so it's the same whenever the user opens the app? By default, other than the favorites section, all other sections should be collapsed.

@yaichenbaum i added the feature you've requested

[gave92]

Couple of notes:

• Minimizing and restoring the app duplicates the "drives" section
• The network drives section is not collapsible
• The blue "selection indicator" is not working for items inside sections
• Expanded state should be saved to AppSettings so it's persisted across app restarts
• Sections should probably have their own icons
• New user pinned folders should be added under the quickaccess section

[yaira2]

@oleitao Is there a way to pin recycle bin regularly instead of putting it at the top of the favorites section?

[gave92]

With the latest commit the bin it's always the last item of the favorites section (like the current behavior on main)

[oleitao]

@oleitao Is there a way to pin recycle bin regularly instead of putting it at the top of the favorites section?

As @gave92 told 'With the latest commit the bin it's always the last item of the favorites section (like the current behavior on main)'

[yaira2]

With the latest commit the bin it's always the last item of the favorites section (like the current behavior on main)

That's should be enough for this pr. In the future, it should be in order of where it was pinned.

[gave92]

Is this the icon we want for favorites?

[oleitao]

Is this the icon we want for favorites?

I added that:

[yaira2]

Is this the icon we want for favorites?

Yes.

[yaira2]

@oleitao One last thing, can you move the home item into the favorites section? Eventually we will let users unpin it from the sidebar, so I think it makes sense to keep it with the other items that can be unpinned.

[oleitao]

@oleitao One last thing, can you move the home item into the favorites section? Eventually we will let users unpin it from the sidebar, so I think it makes sense to keep it with the other items that can be unpinned.

yes, i already moved home item into favorites section

[gave92]

I think it's looking good, just missing the new section icons.

[oleitao]

I think it's looking good, just missing the new section icons.

@gave92 Added favorite section icon commit

[yaira2]

Great work!