Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse command line before App launch #746

Merged
merged 2 commits into from May 5, 2020
Merged

Parse command line before App launch #746

merged 2 commits into from May 5, 2020

Conversation

ADeltaX
Copy link
Contributor

@ADeltaX ADeltaX commented May 4, 2020

No description provided.

@lukeblevins lukeblevins self-requested a review May 4, 2020 20:16
lukeblevins
lukeblevins approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew about the DISABLE_XAML_GENERATED_MAIN parameter, but never thought about using it to improve this area. Great work

@ghost ghost added the needs-review label May 4, 2020
@yaira2 yaira2 changed the base branch from master to develop May 4, 2020 20:39
@yaira2 yaira2 merged commit 7222bfb into files-community:develop May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeblevins lukeblevins lukeblevins approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ADeltaX @lukeblevins @yaira2