Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show selected items size details when selecting by dragging the mouse #9305

Merged

Conversation

IgorKordiukiewicz
Copy link
Contributor

Resolved / Related Issues
Closes #9075

Details of Changes
When selecting items by dragging the mouse, the selected items size details are now shown.

Validation

  • Built and ran the app

Screenshots

drag_selection_details.mp4

@gave92
Copy link
Member

gave92 commented May 31, 2022

Mmm fairly sure we don't call SelectionChanged to avoid performance issues in big folders

@yaira2
Copy link
Member

yaira2 commented May 31, 2022

Mmm fairly sure we don't call SelectionChanged to avoid performance issues in big folders

I seem to recall that we did this in the past but reverted the change because of performance issues.

@yaira2
Copy link
Member

yaira2 commented May 31, 2022

Perhaps a happy medium would be to wait a couple seconds between every update.

@IgorKordiukiewicz
Copy link
Contributor Author

Updated, so now SelectionChanged is called only when selected items have changed.

@gave92 gave92 marked this pull request as draft June 1, 2022 20:04
@gave92
Copy link
Member

gave92 commented Jun 1, 2022

If we were to do this, we could just stop unsubscribing the selection changed event in the PointerPressed event handler.. but the performance issue would persist. We could check again how bad it gets though.

@yaira2
Copy link
Member

yaira2 commented Jul 13, 2022

@IgorKordiukiewicz is this ready for review?

@IgorKordiukiewicz
Copy link
Contributor Author

If we were to do this, we could just stop unsubscribing the selection changed event in the PointerPressed event handler.
I implemented the changes, but haven't tested the performance, so I don't know tbh, maybe it is?

@yaira2
Copy link
Member

yaira2 commented Aug 21, 2022

@gave92 should we move forward with this, if not, what do you want to do here?

@gave92 gave92 marked this pull request as ready for review August 21, 2022 19:59
@gave92 gave92 self-requested a review August 21, 2022 19:59
@yaira2
Copy link
Member

yaira2 commented Aug 21, 2022

@IgorKordiukiewicz thank you!

@yaira2 yaira2 merged commit 8857bb6 into files-community:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the selected item counter while using rectangle selection
3 participants