docs: update that encryption_generated_password_length is deprecated #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there are selenium UI results for this code they will be at filesenderuici@3b920fb |
|
This documentation update relates to #999. |
|
If there are selenium UI results for this code they will be at filesenderuici@7f3906b |
|
If there are selenium UI results for this code they will be at filesenderuici@3b0fda2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FileSender 2.9 (released Oct 5, 2019) encryption_random_password_version_new_files has been 2 which is v2019_generated_password_that_is_full_256bit (from crypto_app.js). This password handling has many advantages such as generating a string that contains the entropy that the system desires and also being a password format known to be generated this way it may skip password hashing.
As the encryption_generated_password_length only applies to v2018_text_password I am deprecating it here. Unless you are setting encryption_random_password_version_new_files to 1 explicitly and then looking to set the max length this setting would have no effect. It is strongly recommended to use the default encryption_random_password_version_new_files=2 (or leaving that setting unset to get the default) as introduced in FileSender 2.9 (released Oct 5, 2019).