admin transfers page: db paging update #1433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #1425
Thanks @makinog3 for the above PR which inspired me to tinker on these updates!
It allows a fake
$total_count
if the offset is zero and there are no real selectors in the SQL query. This is the case for when you first view the admin / transfers page and the totals are likely to be large, somewhat uninteresting, and maybe slow (seq scan on the transfers table).I have also limited the scope of the
for
clause to only consider pages near the current offset rather than from 0 to$total_count
.