Fix erroneous file extension getter #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File extension getter was returning erroneous extension in the case of a directory whose name contains a dot with an extension-less file inside. Example : a `v1.6` folder containing a `OUT` file, the javascript file's name property is `v1.6/OUT`, thus the `getExtension` was returning `6/OUT`, which does not match the file extension regexp and was thus banned. This fix strips the path from the file name before splitting the basename and the extension.
|
If there are selenium UI results for this code they will be at filesenderuici@8d77015 |
|
Looks good. Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File extension getter was returning erroneous extension in the case of a directory whose name contains a dot with an extension-less file inside. Example : a
v1.6folder containing aOUTfile, the javascript file's name property isv1.6/OUT, thus thegetExtensionwas returning6/OUT, which does not match the file extension regexp and was thus banned. This fix strips the path from the file name before splitting the basename and the extension.