Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how requests to CloudRouter are made #47

Closed
shawnmaten opened this issue Jan 5, 2018 · 1 comment
Closed

Refactor how requests to CloudRouter are made #47

shawnmaten opened this issue Jan 5, 2018 · 1 comment
Assignees

Comments

@shawnmaten
Copy link
Contributor

shawnmaten commented Jan 5, 2018

The requests to CloudRouter (the internal service that handles file listing, transfers, etc for cloud storage) are currently made using Retrofit and involve POJO serialization. But the service isn't RESTful, it's really a JSON-RPC, and Retrofit doesn't integrate well with it. And because of its response formatting, it also doesn't work well with POJO serialization.

I think it would be less clunky if we either 1) found a better library to use for this or 2) did something more basic with OkHttp and Gson. I didn't really like this when I made it, but now there's cause to fix it because the awkwardness of trying to map everything to a Java object is partly what lead to an issue in the Android SDK. I mapped the S3 headers to an object, but it turns out I didn't know all the headers to expect.

More formally fixes the below:

@shawnmaten shawnmaten self-assigned this Jan 5, 2018
shawnmaten added a commit that referenced this issue Jan 18, 2018
Related to #47 and #52 but #47 is still necessary.
@shawnmaten
Copy link
Contributor Author

Moved to internal tracker: https://filestack.atlassian.net/browse/FS-3349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant