moved realtests to separate sub directory and ignored from codeclimate

.codeclimate.yml

@@ -13,4 +13,5 @@ exclude_paths:
 - build/*
 - examples/*
 - vendor/*
-- filestack/FilestackConfig.php
+- tests/realtests/*
+- filestack/FilestackConfig.php

.gitignore

@@ -4,5 +4,4 @@ vendor/
 coverage/
 build/logs/*
 tests/testfiles/*
-phpmd-report.xml
 logs/

README.md

@@ -126,7 +126,7 @@ vendor/bin/phpunit
 ```
 
 - To generate coverage report, run following command (will generage html files under
-directory tests/coverage)
+directory coverage/)
 ```
 vendor/bin/phpunit --coverage-html=coverage
 ```
@@ -138,9 +138,10 @@ php php-cs-fixer-v2.phar fix tests/
 php php-cs-fixer-v2.phar fix examples/
 ```
 
-- Run PHPMD for CodeClimate checks
+- To run PHPMD for CodeClimate checks
 ```
-vendor/bin/phpmd filestack xml phpmd-rules.xml > phpmd-report.xml
+vendor/bin/phpmd filestack xml phpmd-rules.xml > logs/phpmd-report-filestack.xml
+vendor/bin/phpmd tests xml phpmd-rules.xml > logs/phpmd-report-tests.xml
 ```
 ## Issues
 

tests/FilelinkTest.php

@@ -77,7 +77,7 @@ public function testFilelinkGetContentNotFound()
         $filelink = new Filelink($this->test_file_handle, $this->test_api_key,
                         $this->test_security, $stub_http_client);
 
-        $result = $filelink->getContent();
+        $filelink->getContent();
     }
 
     /**
@@ -220,7 +220,7 @@ public function testFilelinkDownloadNotFound()
                         $this->test_security, $stub_http_client);
         $destination = __DIR__ . "/testfiles/test.jpg";
 
-        $result = $filelink->download($destination);
+        $filelink->download($destination);
     }
 
     /**
@@ -264,7 +264,7 @@ public function testFilelinkGetMetadataException()
         $filelink = new Filelink('some-bad-file-handle', $this->test_api_key,
                         $this->test_security, $stub_http_client);
 
-        $result = $filelink->getMetaData();
+        $filelink->getMetaData();
     }
 
     /**
@@ -302,7 +302,7 @@ public function testFilelinkDeleteException()
         $filelink = new Filelink('gQNI9RF1SG2nRmvmQDMU', $this->test_api_key,
             $this->test_security, $stub_http_client);
 
-        $result = $filelink->delete();
+        $filelink->delete();
     }
 
     /**
@@ -371,7 +371,7 @@ public function testFilelinkSaveException()
                         $this->test_security,
                         $stub_http_client);
 
-        $result = $filelink->save();
+        $filelink->save();
     }
 
     /**

tests/FilestackClientTest.php

@@ -66,7 +66,7 @@ public function testGetContentNotFound()
             $this->test_api_key,
             $this->test_security,
             $stub_http_client);
-        $result = $client->getContent('some-bad-file-handle-testing');
+        $client->getContent('some-bad-file-handle-testing');
     }
 
     /**
@@ -114,7 +114,7 @@ public function testGetMetadataException()
             $this->test_security,
             $stub_http_client
         );
-        $filelink = $client->getMetaData('some-bad-file-handle-testing');
+        $client->getMetaData('some-bad-file-handle-testing');
     }
 
     /**
@@ -299,7 +299,7 @@ public function testconvertVideoThrowsException()
 
         $source = 'Q5eBTKldRfCSuEjUYuAz';
         $output_options = [];
-        $uuid = $client->convertVideo($source, 'm4a', $output_options);
+        $client->convertVideo($source, 'm4a', $output_options);
     }
 
     /**
@@ -346,7 +346,7 @@ public function testDeleteException()
         );
 
         $test_handle = 'some-bad-file-handle-testing';
-        $result = $client->delete($test_handle);
+        $client->delete($test_handle);
     }
 
     /**
@@ -405,7 +405,7 @@ public function testDownloadNotFound()
             $this->test_security,
             $stub_http_client
         );
-        $result = $client->download('some-bad-file-handle-testing', $destination);
+        $client->download('some-bad-file-handle-testing', $destination);
     }
 
     /**
@@ -479,7 +479,7 @@ public function testUploadInvalidKey()
             $this->test_security,
             $stub_http_client
         );
-        $filelink = $client->upload($this->test_filepath);
+        $client->upload($this->test_filepath);
     }
 
     /**
@@ -531,7 +531,7 @@ public function testUploadSuccessWithOptions()
             'Filename' => 'somefilename.jpg',
         ];
 
-        $filelink = $client->upload($this->test_filepath);
+        $filelink = $client->upload($this->test_filepath, $extras);
 
         $this->assertNotNull($filelink);
     }
@@ -605,10 +605,10 @@ public function testOverwriteException()
             $stub_http_client
         );
 
-        $filelink = $client->overwrite(
-                        $this->test_filepath,
-                        'some-bad-file-handle-testing'
-                    );
+        $client->overwrite(
+            $this->test_filepath,
+            'some-bad-file-handle-testing'
+        );
     }
 
     /**
@@ -700,7 +700,7 @@ public function testDebuggingThrowsException()
             'resize'    => ['w' => 'test-value']
         ];
 
-        $json_response = $client->debug($this->test_file_handle, $transform_tasks);
+        $client->debug($this->test_file_handle, $transform_tasks);
     }
 
     /**
@@ -714,7 +714,7 @@ public function testInvalidMethodThrowExceptions()
         $client = new FilestackClient(
             $this->test_api_key,
             $this->test_security);
-        $result = $client->someInvalidMethod('test');
+        $client->someInvalidMethod('test');
     }
 
     /**
@@ -774,6 +774,6 @@ public function testZipFilesNotFound()
             'some-bad-file-handle-or-url'
         ];
 
-        $contents = $client->zip($sources);
+        $client->zip($sources);
     }
 }

tests/FilestackSecurityTest.php

@@ -37,6 +37,7 @@ public function testSecurityInvalidOptions()
 
         $options = ['some-invalid-option' => 'some-value'];
         $security = new FilestackSecurity($this->test_secret, $options);
+        $this->assertNull($security);
     }
 
     /*
@@ -64,7 +65,7 @@ public function testSecurityDownload()
         $security = new FilestackSecurity($this->test_secret, $options);
         $client = new FilestackClient(
             $this->test_api_key,
-            $this->test_security,
+            $security,
             $stub_http_client
         );
         $result = $client->download($this->test_file_url, $destination);
@@ -96,7 +97,7 @@ public function testDownloadFailedNoCreds()
             null,
             $stub_http_client
         );
-        $result = $client->download($this->test_file_url, $destination);
+        $client->download($this->test_file_url, $destination);
     }
 
     /*
@@ -121,10 +122,10 @@ public function testDownloadFailedInvalidCreds()
         $security = new FilestackSecurity('some-invalid-secret-test');
         $client = new FilestackClient(
             $this->test_api_key,
-            $this->test_security,
+            $security,
             $stub_http_client
         );
-        $result = $client->download($this->test_file_url, $destination);
+        $client->download($this->test_file_url, $destination);
     }
 
     /*

tests/FilestackTransformTest.php

@@ -108,7 +108,7 @@ public function testTransformationFailed()
 
         $filelink = new Filelink($this->test_file_handle, $this->test_api_key,
                         $this->test_security, $stub_http_client);
-        $contents = $filelink->transform($transform_tasks);
+        $filelink->transform($transform_tasks);
     }
 
     /**
@@ -134,7 +134,7 @@ public function testTransformInvalidTaskThrowsException()
 
         $filelink = new Filelink($this->test_file_handle, $this->test_api_key,
                         $this->test_security, $stub_http_client);
-        $contents = $filelink->transform($transform_tasks);
+        $filelink->transform($transform_tasks);
     }
 
     /**
@@ -160,7 +160,7 @@ public function testTransformInvalidAttrThrowsException()
 
         $filelink = new Filelink($this->test_file_handle, $this->test_api_key,
                         $this->test_security, $stub_http_client);
-        $contents = $filelink->transform($transform_tasks);
+        $filelink->transform($transform_tasks);
     }
 
     /**
@@ -469,11 +469,11 @@ public function testCropSuccess()
                         $this->test_api_key,
                         $this->test_security);
 
-        $x = 10;
-        $y = 10;
+        $x_coordinate = 10;
+        $y_coordinate = 10;
         $width = 200;
         $height = 200;
-        $filelink->crop($x, $y, $width, $height);
+        $filelink->crop($x_coordinate, $y_coordinate, $width, $height);
 
         $expected_transform_str = 'crop=d:'. urlencode('[10,10,200,200]');
         $expected_url = sprintf('%s/security=policy:%s,signature:%s/%s/%s',