Feature/fs 980 multiparts upload #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueyl77
force-pushed
the
feature/FS-980-multiparts-upload
branch
from
b34a7b5
to
3525898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified upload() function to use multipart uploads at endpoint https://upload.filestackapi.com
You can tweak the multipart chunk size and number of concurrent jobs by modifying:
FilestackConfig::UPLOAD_CHUNK_SIZE
FilestackConfig::UPLOAD_CONCURRENT_JOBS
Got rid of all the attribute checks in FilestackConfig. We'll just rely on error messages from api instead for invalid attributes, no need to maintain another json reference.
Got rid of createUrl() function in FilestackConfig. It is unnecessary, the function calls will build the URLs themselves.