Skip to content

Commit

Permalink
Added minify_js task
Browse files Browse the repository at this point in the history
  • Loading branch information
Bartek Kwiecien committed Dec 4, 2019
1 parent 4905970 commit 1a6fbf8
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
4 changes: 4 additions & 0 deletions filestack/mixins/imagetransformation.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ def pdf_info(self, colorinfo=None):
def pdf_convert(self, pageorientation=None, pageformat=None, pages=None):
return self._add_transform_task('pdfconvert', locals())

def minify_js(self, gzip=None, use_babel_polyfill=None, keep_fn_name=None, keep_class_name=None,
mangle=None, merge_vars=None, remove_console=None, remove_undefined=None, targets=None):
return self._add_transform_task('minify_js', locals())

def minify_css(self, level=None, gzip=None):
return self._add_transform_task('minify_css', locals())

Expand Down
1 change: 0 additions & 1 deletion filestack/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def return_transform_task(transformation, params):
transform_tasks = []

for key, value in params.items():

if isinstance(value, list):
value = str(value).replace("'", "").replace('"', '').replace(" ", "")
if isinstance(value, bool):
Expand Down
10 changes: 8 additions & 2 deletions tests/transformation_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,18 @@ def test_minify_css(transform):
target_url = '{}/{}/minify_css/{}'.format(config.CDN_URL, APIKEY, EXTERNAL_URL)
result = transform.minify_css()
assert result.url == target_url


def test_minify_css_with_params(transform):
target_url = '{}/{}/minify_css=gzip:false,level:1/{}'.format(config.CDN_URL, APIKEY, EXTERNAL_URL)
result = transform.minify_css(level=1, gzip=False)
assert result.url == target_url
assert result.url == target_url


def test_minify_js(transform):
target_url = '{}/{}/minify_js=gzip:false,targets:not dead,> 1%/{}'.format(config.CDN_URL, APIKEY, EXTERNAL_URL)
result = transform.minify_js(gzip=False, targets='not dead,> 1%')
assert result.url == target_url


def quality(transform):
Expand Down

0 comments on commit 1a6fbf8

Please sign in to comment.