Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minify CSS tasks #46

Merged
merged 6 commits into from
Oct 8, 2019
Merged

Add minify CSS tasks #46

merged 6 commits into from
Oct 8, 2019

Conversation

gowthamraj198
Copy link
Contributor

  • added a new method minify_css with parameters level and gzip of default values of None
  • added tests for the new method.

#45 closes

solyony
solyony suggested changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@solyony solyony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, can you please fix them first.

filestack/mixins/imagetransformation.py Outdated Show resolved Hide resolved
filestack/mixins/imagetransformation.py Outdated Show resolved Hide resolved
tests/transformation_test.py Outdated Show resolved Hide resolved
tests/transformation_test.py Outdated Show resolved Hide resolved
tests/transformation_test.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 97.857% when pulling 2c5513b on gowthamraj198:add_minify_CSS_task into 16fc2e8 on filestack:develop.

@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 97.857% when pulling 3b729d9 on gowthamraj198:add_minify_CSS_task into 16fc2e8 on filestack:develop.

@gowthamraj198
Copy link
Contributor Author

gowthamraj198 commented Oct 7, 2019 •
edited
Loading

Tests are failing, can you please fix them first.

All tests passed. @solyony

solyony
solyony reviewed Oct 7, 2019
View reviewed changes
tests/transformation_test.py Show resolved Hide resolved
tests/transformation_test.py Show resolved Hide resolved
@gowthamraj198
Copy link
Contributor Author

@solyony Thanks for approving! May I know when will this be merged?

@solyony
Copy link
Contributor

solyony commented Oct 7, 2019

@gowthamraj198 Thanks for your PR. We will merge it when @bkwi also take a look.

@gowthamraj198
Copy link
Contributor Author

or your PR. We will merge it when @bkwi also take a look.

Thank you!

@bkwi
Copy link
Contributor

bkwi commented Oct 8, 2019

@gowthamraj198 thanks for taking care of this! 👍
@solyony thanks for reviewing 🙂

@bkwi bkwi merged commit ac25da0 into filestack:develop Oct 8, 2019
@gowthamraj198 gowthamraj198 deleted the add_minify_CSS_task branch October 8, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solyony solyony solyony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gowthamraj198 @coveralls @solyony @bkwi