Rename methods

filestack · Jan 23, 2019 · 7341c4d · 7341c4d
1 parent 8e5f323
commit 7341c4d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/app/helpers/filestack_rails/application_helper.rb b/app/helpers/filestack_rails/application_helper.rb
@@ -7,7 +7,7 @@ def filestack_js_include_tag
       v2 = -> { javascript_include_tag('https://static.filestackapi.com/v3/filestack.js', type: 'text/javascript') }
       v3 = -> { javascript_include_tag('https://static.filestackapi.com/filestack-js/1.x.x/filestack.min.js', type: 'text/javascript') }
 
-      load_filestack_js(v2: v2, v3: v3)
+      get_filestack_js_result(v2: v2, v3: v3)
     end
 
     def filestack_js_init_tag
@@ -62,7 +62,7 @@ def create_javascript_for_picker(callback, options)
                 "(function(){
                   #{client_name}.picker({#{json_string}, onUploadDone: data => #{callback}(data)}).open()
                 })()" }
-      load_filestack_js(v2: v2, v3: v3)
+      get_filestack_js_result(v2: v2, v3: v3)
     end
 
     def get_client_and_api_key

diff --git a/lib/filestack_rails/version.rb b/lib/filestack_rails/version.rb
@@ -1,11 +1,12 @@
 class FilestackVersion
-  def initialize
+  def initialize(results)
     @version = ::Rails.application.config.filestack_rails.version
+    @results = results
   end
 
-  def determine_filestack_js(strategies)
+  def determine_filestack_js_result
     begin
-      strategies[@version.to_sym].call
+      @results[@version.to_sym].call
     rescue
       raise 'Set correct version in config.filestack_rails.version'
     end
@@ -16,8 +17,8 @@ module FilestackRails
   VERSION = '3.2.2'
 
   module Version
-    def load_filestack_js(strategies)
-        FilestackVersion.new.determine_filestack_js(strategies)
+    def get_filestack_js_result(results)
+        FilestackVersion.new(results).determine_filestack_js_result
     end
   end
 end